-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Update Beam version for republish released docker containers workflow #36664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,7 +32,7 @@ on: | |
| - cron: "0 6 * * 1" | ||
| env: | ||
| docker_registry: gcr.io | ||
| release: "${{ github.event.inputs.RELEASE || '2.68.0' }}" | ||
| release: "${{ github.event.inputs.RELEASE || '2.69.0' }}" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I expect this will fail unless we cherry-pick #36583 to the post-release branch, would you mind doing this as well?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can be in a follow up pr
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| rc: "${{ github.event.inputs.RC || '2' }}" | ||
|
|
||
| jobs: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
possible to get the latest Beam version automatically instead of updating this with every release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its actually surprisingly tricky because of the ordering of things (you need the release before checkout). So its possible, but maybe more trouble than its worth. An easier version might be to auto-update this as part of our other post-release workflows.