-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[Elasticsearch] Add support for v9.x #36670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Elasticsearch] Add support for v9.x #36670
Conversation
750daa9 to
16baed4
Compare
|
Assigning reviewers: R: @m-trieu for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
@m-trieu Any guidance on how to execute the Elasticsearch unit tests? I took a quick look over https://github.com/apache/beam/blob/master/.github/workflows/README.md but I'm not yet clear on how to execute the unit tests for ES |
|
Reminder, please take a look at this pr: @m-trieu |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @Abacn for label java. Available commands:
|
|
Ran also need to add the test target to github action script
|
|
@Abacn thanks! Both should now be fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this LGTM
We may add an annoucement to CHANGES.md, either in this PR or as a follow up
* (Java) Elasticsearch 9 Support for ElasticsearchIO ([#36491](https://github.com/apache/beam/issues/36491)).
Line 71 in 81bb506
| * Support for X source added (Java/Python) ([#X](https://github.com/apache/beam/issues/X)). |
|
Good call @Abacn, added! |
Fixes #36491 by adding support for Elasticsearch v9.x
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.