Fix Docker image tagging for buildx by pulling when missing

[aIbrahiim]

Fixes: #30519

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello @aIbrahiim, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where Docker image builds and pushes were failing due to images not being present locally or not being properly handled by buildx. It refines the Docker push commands by removing the gcloud docker prefix and, more significantly, introduces a comprehensive fallback mechanism for Python Docker images. This mechanism ensures that if an image is not found locally, the system attempts to build it via buildx or pull it from the registry, improving the reliability of the Docker image build and deployment process.

Highlights

• Docker Push Command Streamlining: The gcloud docker -- push command has been replaced with a direct docker push command in the build.gradle files for both Java and Python Docker image builds, simplifying the push operation.
• Robust Docker Image Availability Check: Enhanced the Python Docker image build process to first check for the image locally. If not found, it attempts to build it using docker buildx build --load, and if that fails, it tries to pull the image from the registry. A GradleException is thrown if the image cannot be found or built through any of these methods.
• Docker Authentication Verification: A docker info command has been added before pushing the Python Docker image to explicitly verify Docker authentication, providing clearer feedback in case of authentication issues.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/beam_PostCommit_XVR_GoUsingJava_Dataflow.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

[aIbrahiim]

@Abacn , I think these 2 checks are failing with Unauthenticated request errors. I added Docker authentication steps to the workflows and set CLOUDSDK_CONFIG in all Gradle steps, but the service account probably needs roles/storage.admin for GCR (us.gcr.io)