Skip to content

DO NOT MERGE: removing timestamp validation in FnApiDoFnRunner #36822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kennknowles wants to merge 2 commits into
base: master
Choose a base branch
from
Open

DO NOT MERGE: removing timestamp validation in FnApiDoFnRunner #36822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cd51f5
Remove SimpleDoFnRunner timestamp check
kennknowles Nov 17, 2025
145ff8f
Touch trigger files
kennknowles Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Dataflow.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"https://github.com/apache/beam/pull/36822": "Testing removal of a timestamp check",
"https://github.com/apache/beam/pull/34902": "Introducing OutputBuilder",
"comment": "Modify this file in a trivial way to cause this test suite to run",
"modification": 2,
Expand Down
1 change: 1 addition & 0 deletions .github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"https://github.com/apache/beam/pull/36822": "Testing removal of a timestamp check",
"https://github.com/apache/beam/pull/34902": "Introducing OutputBuilder",
"comment": "Modify this file in a trivial way to cause this test suite to run",
"https://github.com/apache/beam/pull/31156": "noting that PR #31156 should run this test",
Expand Down
1 change: 1 addition & 0 deletions .github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Direct.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"https://github.com/apache/beam/pull/36822": "Testing removal of a timestamp check",
"https://github.com/apache/beam/pull/34902": "Introducing OutputBuilder",
"https://github.com/apache/beam/pull/35213": "Eliminating getPane() in favor of getPaneInfo()",
"https://github.com/apache/beam/pull/35177": "Introducing WindowedValueReceiver to runners",
Expand Down
1 change: 1 addition & 0 deletions .github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Flink.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"https://github.com/apache/beam/pull/36822": "Testing removal of a timestamp check",
"https://github.com/apache/beam/pull/34902": "Introducing OutputBuilder",
"https://github.com/apache/beam/pull/35213": "Eliminating getPane() in favor of getPaneInfo()",
"https://github.com/apache/beam/pull/35177": "Introducing WindowedValueReceiver to runners",
Expand Down
1 change: 1 addition & 0 deletions .github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Spark.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"https://github.com/apache/beam/pull/36822": "Testing removal of a timestamp check",
"https://github.com/apache/beam/pull/34902": "Introducing OutputBuilder",
"https://github.com/apache/beam/pull/35213": "Eliminating getPane() in favor of getPaneInfo()",
"https://github.com/apache/beam/pull/35177": "Introducing WindowedValueReceiver to runners",
Expand Down
1 change: 0 additions & 1 deletion runners/core-java/src/main/java/org/apache/beam/runners/core/SimpleDoFnRunner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,6 @@ public <T> void outputWindowedValue(
.setPaneInfo(paneInfo)
.setReceiver(
wv -> {
checkTimestamp(elem.getTimestamp(), wv.getTimestamp());
SimpleDoFnRunner.this.outputWindowedValue(tag, wv);
})
.output();
Expand Down
2 changes: 1 addition & 1 deletion sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1860,7 +1860,7 @@ public OutputBuilder<OutputT> builder(OutputT value) {
.withValue(value)
.setReceiver(
windowedValue -> {
checkTimestamp(windowedValue.getTimestamp());
// checkTimestamp(windowedValue.getTimestamp());
outputTo(mainOutputConsumer, windowedValue);
});
}
Expand Down
Loading