Skip to content

GCS client library migration in Java SDK - part 1 #36876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shunping wants to merge 9 commits into
base: master
Choose a base branch
from
Open

GCS client library migration in Java SDK - part 1 #36876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f25cb2d
Make a copy of GcsUtil.java as GcsUtilLegacy.java
shunping Nov 21, 2025
7e325ab
Change references from GcsUtil to GcsUtilLegacy in GcsUtilLegacy.java
shunping Nov 21, 2025
eddfddc
Change public apis in GcsUtil.java to call the GcsUtilLegacy.java
shunping Nov 21, 2025
b57e603
Add mocking GcsUtilLegacy for tests and remove unnecessary references…
shunping Nov 22, 2025
a78c983
Possible breaking change: removed unused public functions.
shunping Nov 22, 2025
62f8d66
Get rid of the last bit (read option) gcsio references in GcsUtil.java.
shunping Nov 22, 2025
8d0bbaa
Route the code path of open reading files to include api count metric.
shunping Nov 22, 2025
70fcc3f
Spotless check
shunping Nov 22, 2025
de37131
Remove BatchInterface and RewriteOp from GcsUtil.java. Simplify some …
shunping Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...ud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/options/GcsOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import org.apache.beam.sdk.extensions.gcp.storage.GcsPathValidator;
import org.apache.beam.sdk.extensions.gcp.storage.PathValidator;
import org.apache.beam.sdk.extensions.gcp.util.GcsUtil;
import org.apache.beam.sdk.extensions.gcp.util.GcsUtilLegacy;
import org.apache.beam.sdk.options.ApplicationNameOptions;
import org.apache.beam.sdk.options.Default;
import org.apache.beam.sdk.options.DefaultValueFactory;
Expand All @@ -49,7 +50,7 @@ public interface GcsOptions extends ApplicationNameOptions, GcpOptions, Pipeline
@JsonIgnore
@Description(
"The GoogleCloudStorageReadOptions instance that should be used to read from Google Cloud Storage.")
@Default.InstanceFactory(GcsUtil.GcsReadOptionsFactory.class)
@Default.InstanceFactory(GcsUtilLegacy.GcsReadOptionsFactory.class)
Copy link
Contributor

@Abacn Abacn Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "GcsUtilV1" (and latest version of the class still as GcsUtil)? this follows other branched classes naming convention, and in case they both exist in Beam code base for extended time and a "GcsUtilV3" appear in the future (hopefuly won't be the case).

@Hidden
GoogleCloudStorageReadOptions getGoogleCloudStorageReadOptions();

Expand Down
Loading
Loading