Skip to content

Fix linkage check script to handle detached HEAD state #36924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kennknowles merged 1 commit into from
Dec 1, 2025
Merged

Fix linkage check script to handle detached HEAD state #36924

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions sdks/java/build-tools/beam-linkage-check.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,12 @@ if [ ! -z "$(git diff)" ]; then
exit 1
fi

STARTING_REF=$(git rev-parse --abbrev-ref HEAD)
# Use the full commit SHA instead of branch name to handle detached HEAD state.
# This commonly happens when verifying someone else's PR, which involves
# merging two non-branch references. See https://github.com/apache/beam/issues/20558
STARTING_REF=$(git rev-parse HEAD)
function cleanup() {
git checkout $STARTING_REF
git -c advice.detachedHead=false checkout $STARTING_REF
}
trap cleanup EXIT

Expand Down
Loading