Skip to content

fix: withErrorHandler is not supported with File_Load #36937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liferoad wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: withErrorHandler is not supported with File_Load #36937

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions ...a/org/apache/beam/sdk/io/gcp/bigquery/providers/BigQueryWriteSchemaTransformProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@
import static org.apache.beam.sdk.util.construction.BeamUrns.getUrn;

import com.google.auto.service.AutoService;
import java.util.Arrays;
import java.util.List;
import org.apache.beam.model.pipeline.v1.ExternalTransforms;
import org.apache.beam.sdk.annotations.Internal;
import org.apache.beam.sdk.schemas.NoSuchSchemaException;
Expand Down Expand Up @@ -47,6 +49,11 @@ public String identifier() {
return getUrn(ExternalTransforms.ManagedTransforms.Urns.BIGQUERY_WRITE);
}

@Override
public List<String> outputCollectionNames() {
return Arrays.asList("FailedRows", "FailedRowsWithErrors", "errors");
}

@Override
protected SchemaTransform from(BigQueryWriteConfiguration configuration) {
return new BigQueryWriteSchemaTransform(configuration);
Expand All @@ -62,9 +69,10 @@ public static class BigQueryWriteSchemaTransform extends SchemaTransform {

@Override
public PCollectionRowTuple expand(PCollectionRowTuple input) {
if (input.getSinglePCollection().isBounded().equals(PCollection.IsBounded.BOUNDED)) {
if (input.getSinglePCollection().isBounded().equals(PCollection.IsBounded.BOUNDED)
&& configuration.getErrorHandling() == null) {
return input.apply(new BigQueryFileLoadsSchemaTransformProvider().from(configuration));
} else { // UNBOUNDED
} else { // UNBOUNDED or error handling specified
return input.apply(
new BigQueryStorageWriteApiSchemaTransformProvider().from(configuration));
}
Expand Down
Loading