Skip to content

Replace VarInt.getLength with Protobuf's branchless implementation #36959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sjvanrossum wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Replace VarInt.getLength with Protobuf's branchless implementation #36959

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8a82c18
Replace VarInt.getLength with Protobuf's branchless implementation
sjvanrossum Dec 2, 2025
07b1ee1
Use CodedOutputStream's computeUInt32SizeNoTag and computeUInt64SizeN…
sjvanrossum Dec 2, 2025
f859813
Run spotless
sjvanrossum Dec 3, 2025
76fc879
Merge remote-tracking branch 'origin/master' into varint-get-length
sjvanrossum Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions sdks/java/core/src/main/java/org/apache/beam/sdk/util/VarInt.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
*/
package org.apache.beam.sdk.util;

import com.google.protobuf.CodedOutputStream;
import java.io.EOFException;
import java.io.IOException;
import java.io.InputStream;
Expand Down Expand Up @@ -136,16 +137,11 @@ public static long decodeLong(InputStream stream) throws IOException {

/** Returns the length of the encoding of the given value (in bytes). */
public static int getLength(int v) {
return getLength(convertIntToLongNoSignExtend(v));
return CodedOutputStream.computeUInt32SizeNoTag(v);
}

/** Returns the length of the encoding of the given value (in bytes). */
public static int getLength(long v) {
int result = 0;
do {
result++;
v >>>= 7;
} while (v != 0);
return result;
return CodedOutputStream.computeUInt64SizeNoTag(v);
}
}
Loading