Skip to content

Cache DynamicDestinationsHelper.ConstantTimePartitioningClusteringDestination clustering & partitioning #37014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stankiewicz wants to merge 1 commit into
base: master
Choose a base branch
from
+37 −10
Open

Cache DynamicDestinationsHelper.ConstantTimePartitioningClusteringDestination clustering & partitioning #37014

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 37 additions & 10 deletions ...latform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/DynamicDestinationsHelpers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
import java.io.IOException;
import java.util.List;
import java.util.Map;
import java.util.Optional;
import java.util.concurrent.atomic.AtomicBoolean;
import org.apache.beam.sdk.coders.CannotProvideCoderException;
import org.apache.beam.sdk.coders.Coder;
import org.apache.beam.sdk.coders.CoderRegistry;
Expand Down Expand Up @@ -279,6 +279,11 @@ static class ConstantTimePartitioningClusteringDestinations<T>
private final @Nullable ValueProvider<String> jsonTimePartitioning;
private final @Nullable ValueProvider<String> jsonClustering;

// Lazily initialized and cached values.
private @Nullable String evaluatedPartitioning = null;
private @Nullable String evaluatedClustering = null;
private final AtomicBoolean initialized = new AtomicBoolean(false);

ConstantTimePartitioningClusteringDestinations(
DynamicDestinations<T, TableDestination> inner,
ValueProvider<String> jsonTimePartitioning,
Expand All @@ -299,19 +304,41 @@ static class ConstantTimePartitioningClusteringDestinations<T>
this.jsonClustering = jsonClustering;
}

static boolean isJsonConfigPresent(ValueProvider<String> json) {
String jsonValue = json.get();
return jsonValue != null && !JsonParser.parseString(jsonValue).getAsJsonObject().isEmpty();
}

private synchronized void evaluateOncePartitioningAndClustering() {
if (initialized.get()) {
return;
}
if (jsonTimePartitioning != null) {
if (isJsonConfigPresent(jsonTimePartitioning)) {
this.evaluatedPartitioning = jsonTimePartitioning.get();
}
}
if (jsonClustering != null) {
if (isJsonConfigPresent(jsonClustering)) {
this.evaluatedClustering = jsonClustering.get();
}
}
initialized.set(true);
}

@Override
public TableDestination getDestination(@Nullable ValueInSingleWindow<T> element) {
if (!initialized.get()) {
evaluateOncePartitioningAndClustering();
}
TableDestination destination = super.getDestination(element);

String partitioning =
Optional.ofNullable(jsonTimePartitioning).map(ValueProvider::get).orElse(null);
if (partitioning == null
|| JsonParser.parseString(partitioning).getAsJsonObject().isEmpty()) {
partitioning = destination.getJsonTimePartitioning();
}
String clustering = Optional.ofNullable(jsonClustering).map(ValueProvider::get).orElse(null);
if (clustering == null || JsonParser.parseString(clustering).getAsJsonObject().isEmpty()) {
clustering = destination.getJsonClustering();
}
evaluatedPartitioning != null
? evaluatedPartitioning
: destination.getJsonTimePartitioning();
String clustering =
evaluatedClustering != null ? evaluatedClustering : destination.getJsonClustering();

return new TableDestination(
destination.getTableSpec(), destination.getTableDescription(), partitioning, clustering);
Expand Down
Loading