Skip to content

[Prism] Set keepalive policy for grpc server. #37021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shunping merged 2 commits into from
Dec 8, 2025
Merged

[Prism] Set keepalive policy for grpc server. #37021

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b28cc6f
Set keepalive policy for prism grpc server.
shunping Dec 6, 2025
3aa6714
Merge branch 'master' into prism-grpc-server-options
shunping Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions sdks/go/pkg/beam/runners/prism/internal/jobservices/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import (
jobpb "github.com/apache/beam/sdks/v2/go/pkg/beam/model/jobmanagement_v1"
"github.com/apache/beam/sdks/v2/go/pkg/beam/runners/prism/internal/worker"
"google.golang.org/grpc"
"google.golang.org/grpc/keepalive"
)

type Server struct {
Expand Down Expand Up @@ -80,6 +81,10 @@ func NewServer(port int, execute func(*Job)) *Server {
s.logger.Info("Serving JobManagement", slog.String("endpoint", s.Endpoint()))
opts := []grpc.ServerOption{
grpc.MaxRecvMsgSize(math.MaxInt32),
grpc.KeepaliveEnforcementPolicy(keepalive.EnforcementPolicy{
MinTime: 20 * time.Second, // Minimum duration a client should wait before sending a keepalive ping
Copy link
Collaborator Author

@shunping shunping Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 20-second min time matches the option set in the python client:

https://github.com/liferoad/beam/blob/782a0e7cc26e582c31534253fa5a00018bce4c38/sdks/python/apache_beam/runners/worker/channel_factory.py#L27

PermitWithoutStream: true, // Allow pings even if there are no active streams
}),
}
s.server = grpc.NewServer(opts...)
jobpb.RegisterJobServiceServer(s.server, s)
Expand Down
Loading