-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Add nanosecond timestamp support for Storage write when writing GenericRecords and Beam Rows #37235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @claudevdm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the BigQuery Storage Write API integration by introducing comprehensive support for nanosecond-precision timestamps. It enables users to accurately store and retrieve time-series data with sub-microsecond granularity when using both Avro GenericRecords and Beam Rows, aligning with BigQuery's Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for nanosecond-precision timestamps when writing to BigQuery using the Storage Write API, for both Avro GenericRecords and Beam Rows. The changes are well-implemented and include corresponding tests. I've provided a few suggestions to improve code clarity, reduce duplication, and enhance maintainability by using constants for magic numbers and refactoring some logic.
...rm/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/AvroGenericRecordToStorageApiProto.java
Outdated
Show resolved
Hide resolved
...rm/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/AvroGenericRecordToStorageApiProto.java
Outdated
Show resolved
Hide resolved
...oud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BeamRowToStorageApiProto.java
Show resolved
Hide resolved
...o/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryUtils.java
Outdated
Show resolved
Hide resolved
...oud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryTimestampPicosIT.java
Outdated
Show resolved
Hide resolved
|
R: @Abacn |
|
R: @damccorm |
|
R: @ahmedabu98 |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
2 similar comments
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
/gemini review |
damccorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for nanosecond-precision timestamps for the BigQuery Storage Write API, for both Avro GenericRecords and Beam Rows. The changes are well-structured, covering schema conversion, data conversion, and comprehensive new tests. The logic for handling nanosecond timestamps, including negative timestamps, appears correct. I've made a few suggestions to improve code clarity and maintainability, mainly by replacing magic numbers with named constants and simplifying some arithmetic logic. Overall, this is a solid contribution.
This PR adds support for writing nanosecond-precision timestamps to BigQuery via the Storage Write API. BigQuery's
TIMESTAMPtype with precision 12 (picoseconds) can store timestamps with sub-microsecond precision.Changes
1. Avro GenericRecord Support (
AvroGenericRecordToStorageApiProto.java)timestamp-nanoslogical typeTIMESTAMPwithtimestampPrecision = 12Long(nanoseconds since epoch) →TimestampPicosproto message{seconds, picoseconds}2. Beam Row Support (
BeamRowToStorageApiProto.java)Timestamp.NANOSlogical type (precision = 9)TIMESTAMPwithtimestampPrecision = 12java.time.Instant→TimestampPicosproto message{seconds, picoseconds}3. BigQuery Avro Utils (
BigQueryAvroUtils.java)timestampPrecision = 12when readingtimestamp-nanosfieldsThank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.