Skip to content

Conversation

@derrickaw
Copy link
Collaborator

Fixes #36086


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @derrickaw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the testing coverage for Apache Beam's YAML pipeline expansion feature. It introduces new unit tests to specifically validate the expand_pipeline function's schema validation capabilities, ensuring that both valid and invalid YAML pipeline definitions are handled appropriately. This helps maintain the integrity and reliability of YAML-based pipeline construction.

Highlights

  • YAML Pipeline Schema Validation: Added unit tests to verify the expand_pipeline function's behavior when validating YAML pipeline definitions against a schema.
  • Valid Schema Test Case: Introduced test_expand_pipeline_with_valid_schema to confirm that pipelines with correctly structured YAML are expanded without errors when schema validation is enabled.
  • Invalid Schema Test Case: Implemented test_expand_pipeline_with_invalid_schema to ensure that expand_pipeline correctly raises a jsonschema.ValidationError when processing YAML definitions that do not conform to the expected schema.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@derrickaw derrickaw marked this pull request as ready for review January 8, 2026 21:20
@derrickaw
Copy link
Collaborator Author

Failures don't seem related

@derrickaw
Copy link
Collaborator Author

Run Xlang_Generated_Transforms PreCommit 3.10

@derrickaw derrickaw changed the title [yaml] : Add final exand pipeline ut [yaml] : Add final expand pipeline ut Jan 8, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@derrickaw
Copy link
Collaborator Author

Run Python_Runners PreCommit 3.10

@derrickaw
Copy link
Collaborator Author

Run Xlang_Generated_Transforms PreCommit 3.10

@derrickaw
Copy link
Collaborator Author

Run Prism_Python PreCommit 3.10

@derrickaw
Copy link
Collaborator Author

Run Prism_Python PreCommit 3.13

@derrickaw
Copy link
Collaborator Author

Run Python_PVR_Flink PreCommit

@derrickaw
Copy link
Collaborator Author

Run Xlang_Generated_Transforms PreCommit 3.10

@derrickaw
Copy link
Collaborator Author

Run Python_PVR_Flink PreCommit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: add a yaml ut for expand_pipeline

1 participant