Skip to content

Conversation

@jrmccluskey
Copy link
Contributor

Removes outdated/standalone usages of the apitools HttpError exception class.

Part of #35611


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @jrmccluskey, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modernizes the exception handling mechanisms within the Apache Beam Python SDK, specifically for interactions with Google Cloud Platform (GCP) APIs. It systematically replaces the deprecated apitools.base.py.exceptions.HttpError with contemporary and more granular exceptions from the google.api_core.exceptions module. This change ensures consistency with current best practices for GCP client libraries and improves the clarity and specificity of error handling across various GCP I/O connectors and testing utilities.

Highlights

  • Exception Handling Modernization: Replaced outdated apitools.base.py.exceptions.HttpError with more current and specific exceptions from google.api_core.exceptions, primarily GoogleAPICallError and NotFound.
  • Code Cleanup: Removed redundant except HttpError as e: blocks where the exceptions were already covered by ClientError or GoogleAPICallError.
  • Test Updates: Updated unittest.skipIf conditions and exception assertions in tests to reflect the new exception types.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@jrmccluskey
Copy link
Contributor Author

@gemini-code-assist review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes outdated usages of apitools.base.py.exceptions.HttpError and replaces them with exceptions from google.api_core.exceptions. The changes are mostly straightforward replacements and removals of dead code, which improves consistency and removes dependency on an older library.

The changes in test files to use more specific exceptions like google.api_core.exceptions.NotFound are a good improvement.

I have one minor suggestion for consistency in a test file's skip message. Overall, the changes look good and align with the goal of the pull request.


@patch.object(GCSFileSystem, 'match')
@unittest.skipIf(HttpError is None, 'google-apitools is not installed')
@unittest.skipIf(GoogleAPICallError is None, 'google-apitools is not installed')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other files in this PR, could you update the skip message to 'GCP dependencies are not installed'?

Suggested change
@unittest.skipIf(GoogleAPICallError is None, 'google-apitools is not installed')
@unittest.skipIf(GoogleAPICallError is None, 'GCP dependencies are not installed')

@github-actions
Copy link
Contributor

Assigning reviewers:

R: @damccorm for label python.
R: @nielm for label spanner.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant