Skip to content

Conversation

@tarun-google
Copy link
Contributor

Cherry Pick RateLimiter SDK changes to Beam 2.71 release

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

* Support for EnvoyRateLimiter in Apache Beam

* fix format issues

* fix test formatting

* Fix test and syntax

* fix lint

* Add dependency based on python version

* revert setup to separete pr

* fix lint

* fix formatting

* resolve comments

* Support Ratelimiter through RemoteModelHandler

* fix lint

* fix lint

* fix comments

* Add custom RateLimited Exception

* fix doc

* fix test

* fix lint
* Catch Import Error

* import order
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @tarun-google, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request cherry-picks a set of changes related to the RateLimiter SDK into the Beam 2.71 release. The primary goal is to refine the rate limiting mechanism by renaming key methods for clarity, enhancing the EnvoyRateLimiter for distributed environments through serialization support, and integrating this rate limiting capability directly into the ML inference framework. These updates provide more robust control over external service interactions within Beam pipelines.

Highlights

  • Rate Limiter Method Renaming: The core rate limiting method has been renamed from throttle() to allow() across the RateLimiter abstract base class and its EnvoyRateLimiter implementation. This change clarifies the method's intent, indicating whether a request is permitted rather than just if it's being throttled.
  • EnvoyRateLimiter Serialization Support: Added __getstate__ and __setstate__ methods to the EnvoyRateLimiter class. This enables proper serialization and deserialization of the rate limiter, which is crucial for Beam's distributed processing where objects might need to be pickled and unpickled across workers.
  • Integration with ML Inference Handlers: The RemoteModelHandler in apache_beam.ml.inference.base now supports an optional rate_limiter parameter. This allows users to apply a global rate limit to inference requests, ensuring that external ML services are not overwhelmed. A new RateLimitExceeded exception has also been introduced.
  • New Vertex AI Rate Limiter Example: A new example file, rate_limiter_vertex_ai.py, has been added. This example demonstrates how to use the EnvoyRateLimiter in conjunction with VertexAIModelHandlerJSON to control the rate of inference requests to a Vertex AI endpoint.
  • Updated Test Cases: Existing test cases for the EnvoyRateLimiter have been updated to reflect the throttle() to allow() method rename. Additionally, new test cases have been added to base_test.py to validate the integration of the rate limiter within the RunInference transform and to test scenarios where rate limits are exceeded.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@Abacn
Copy link
Contributor

Abacn commented Jan 14, 2026

Consider add an item under new feature in https://github.com/apache/beam/blob/master/CHANGES.md

@tarun-google
Copy link
Contributor Author

created #37308 should i cherrypick this too after merging?

@tarun-google
Copy link
Contributor Author

@damccorm

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damccorm damccorm merged commit 0c4d81b into apache:release-2.71 Jan 14, 2026
100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants