Skip to content

Fix python postcommit 30513#37849

Merged
Abacn merged 2 commits intoapache:masterfrom
aIbrahiim:fix-python-postcommit-30513
Mar 13, 2026
Merged

Fix python postcommit 30513#37849
Abacn merged 2 commits intoapache:masterfrom
aIbrahiim:fix-python-postcommit-30513

Conversation

@aIbrahiim
Copy link
Contributor

Fixes: #30513
Successful run: https://github.com/apache/beam/actions/runs/23050146487

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a Python postcommit issue by streamlining the image embedding test data handling. It refactors a specific test case to directly utilize image bytes, thereby removing redundant file system interactions and simplifying the test's execution flow.

Highlights

  • Test Refinement: The test_image_embedding_pipeline_from_path test in vertex_ai_test.py was refactored to simplify its setup.
  • Direct Byte Usage: The test now directly uses image bytes (png_bytes) when creating an EmbeddableItem, eliminating the need to write them to a temporary file and then read from its path.
  • Simplified Test Setup: This change removes unnecessary file system operations, making the test cleaner, more efficient, and less prone to file-related issues.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • sdks/python/apache_beam/ml/rag/embeddings/vertex_ai_test.py
    • Modified the test_image_embedding_pipeline_from_path test to directly use image bytes instead of a file path for EmbeddableItem creation.
    • Removed temporary file creation and associated file I/O operations within the test.
Activity
  • No human activity has occurred on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@aIbrahiim aIbrahiim force-pushed the fix-python-postcommit-30513 branch from 6c24ec2 to b639951 Compare March 13, 2026 15:36
@Amar3tto Amar3tto requested a review from Abacn March 13, 2026 16:10
@Abacn
Copy link
Contributor

Abacn commented Mar 13, 2026

Was it caused by breaking change on vertax AI library?

@aIbrahiim
Copy link
Contributor Author

Was it caused by breaking change on vertax AI library?

@Abacn no this wasn’t caused by a vertex AI breaking change as the failure came from the test using a driver local temp file path that isnt visible on Dataflow workers which lead to a FileNotFoundError when the worker tried to load the image

@Abacn Abacn merged commit d6d2433 into apache:master Mar 13, 2026
94 of 97 checks passed
@Abacn
Copy link
Contributor

Abacn commented Mar 13, 2026

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PostCommit Python job is flaky

2 participants