Filter empty string for networkTopologyScriptFileName#1952
Merged
sijie merged 1 commit intoapache:masterfrom Feb 20, 2019
Merged
Filter empty string for networkTopologyScriptFileName#1952sijie merged 1 commit intoapache:masterfrom
sijie merged 1 commit intoapache:masterfrom
Conversation
- filter empty string for networkTopologyScriptFileName.
eolivelli
approved these changes
Feb 19, 2019
sijie
approved these changes
Feb 20, 2019
Member
|
run bookkeeper-server replication tests |
sijie
pushed a commit
that referenced
this pull request
Feb 20, 2019
Descriptions of the changes in this PR: - filter empty string for networkTopologyScriptFileName. Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Sijie Guo <sijie@apache.org> This closes #1952 from reddycharan/ignoreemptystring (cherry picked from commit 166be82) Signed-off-by: Sijie Guo <sijie@apache.org>
Contributor
|
@sijie you marked this one for 4.9.0 but it is not true, it has been cherry picked after 4.9.0 release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR: