Issue #1987: Migrate command convert-to-interleaved-storage#1988
Merged
sijie merged 7 commits intoapache:masterfrom Mar 25, 2019
Merged
Issue #1987: Migrate command convert-to-interleaved-storage#1988sijie merged 7 commits intoapache:masterfrom
convert-to-interleaved-storage#1988sijie merged 7 commits intoapache:masterfrom
Conversation
sijie
approved these changes
Mar 15, 2019
Member
sijie
left a comment
sijie
left a comment
There was a problem hiding this comment.
overall looks good. left one minor comment.
| @Test | ||
| public void testConvertToInterleavedStorageCommand() { | ||
| ConvertToInterleavedStorageCommand cmd = new ConvertToInterleavedStorageCommand(); | ||
| Assert.assertTrue(cmd.apply(bkFlags, new String[] { "" })); |
Member
There was a problem hiding this comment.
I think it would be better to verify the command is executing as expected. e.g. verify if those methods are called
jiazhai
approved these changes
Mar 16, 2019
Member
Author
|
run integration tests |
sijie
approved these changes
Mar 18, 2019
Member
|
run integration tests |
Member
|
@zymap it seems that CI is not passing, can you check? |
Member
Author
|
@sijie ok, i will check it later |
Member
Author
|
run bookkeeper-server bookie tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
convert-to-interleaved-storageMotivation
convert-to-interleaved-storage#1987bkctlto run commandconvert-to-interleaved-storageChanges
bookiegroup