[ISSUE 3287] Fix the bug that ipv6 ip can not be recognized#3288
Open
tal705 wants to merge 1 commit intoapache:masterfrom
Open
[ISSUE 3287] Fix the bug that ipv6 ip can not be recognized#3288tal705 wants to merge 1 commit intoapache:masterfrom
tal705 wants to merge 1 commit intoapache:masterfrom
Conversation
Author
|
@sijie could you review it? thank you very much. |
Author
|
rerun failure checks |
Author
|
rerun failure checks |
hangc0276
reviewed
Jun 24, 2022
| multiHosts.toArray(new String[multiHosts.size()]), | ||
| serviceURI.getServicePath(), | ||
| serviceURI.getUri()); | ||
| } |
Contributor
There was a problem hiding this comment.
Do we need to deal with hosts.size() == 1 ?
Contributor
|
The same with #3158 |
Member
|
fix old workflow,please see #3455 for detail |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #3287
Fix the bug for ipv6 ip can not be recognized.
Changes
org.apache.bookkeeper.common.net.ServiceURIto deal with ipv6 ip.