Closed
Conversation
Using `maven-wrapper` can save users from installing maven, and can lock the version, at the same time, improve our build time. 3.X's `maven-warpper` performance has been greatly improved.
StevenLuMT
requested changes
Jul 20, 2022
Member
StevenLuMT
left a comment
StevenLuMT
left a comment
There was a problem hiding this comment.
improve build time from *** to ***
do you have some test data?
Member
Author
He has about 10% improvement on my M1 machine, which is also an optimization made by the official. |
Member
|
fix old workflow,please see #3455 for detail |
nicoloboschi
reviewed
Jan 5, 2023
Contributor
nicoloboschi
left a comment
nicoloboschi
left a comment
There was a problem hiding this comment.
@CalvinKirs could you rebase ?
Contributor
|
@CalvinKirs Thanks for your contribution. Would you please rebase the master and resolve the conflicts? Thanks a lot. After those conflicts are resolved, I will move back to the 4.16.0. |
Member
|
@CalvinKirs Are you still want to working on this? Could you please rebase the master code? Thanks |
Member
|
closed by no updte, feel free to reopen it if you still want to working on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Using
maven-wrappercan save users from installing maven,and can lock the version, at the same time, improve our build time. 3.X's
maven-warpperperformance has been greatly improved.