Closed
Conversation
Member
Author
hangc0276
requested review from
eolivelli,
hangc0276,
hezhangjian,
nicoloboschi and
zymap
dlg99
reviewed
Jul 28, 2022
Comment on lines
+3875
to
+3884
| Object writeCacheConf = this.getProperty(DbLedgerStorage.WRITE_CACHE_MAX_SIZE_MB); | ||
| if (writeCacheConf instanceof Number) { | ||
| writeCacheMb = ((Number) writeCacheConf).longValue(); | ||
| } else if (writeCacheConf == null) { | ||
| writeCacheMb = DbLedgerStorage.DEFAULT_WRITE_CACHE_MAX_SIZE_MB; | ||
| } else if (StringUtils.isEmpty(this.getString(DbLedgerStorage.WRITE_CACHE_MAX_SIZE_MB))) { | ||
| writeCacheMb = DbLedgerStorage.DEFAULT_WRITE_CACHE_MAX_SIZE_MB; | ||
| } else { | ||
| writeCacheMb = this.getLong(DbLedgerStorage.WRITE_CACHE_MAX_SIZE_MB); | ||
| } |
Contributor
There was a problem hiding this comment.
I think all this can be done better by moving
long writeCacheMaxSize = getLongVariableOrDefault(conf, WRITE_CACHE_MAX_SIZE_MB,
DEFAULT_WRITE_CACHE_MAX_SIZE_MB) * MB;
long readCacheMaxSize = getLongVariableOrDefault(conf, READ_AHEAD_CACHE_MAX_SIZE_MB,
DEFAULT_READ_CACHE_MAX_SIZE_MB) * MB;
boolean directIOEntryLogger = getBooleanVariableOrDefault(conf, DIRECT_IO_ENTRYLOGGER, false);
and related config magic out of DbLedgerStorage into the ServerConfig
and then all you'd need to do is something like this.getWriteCacheMaxSize()
Member
There was a problem hiding this comment.
Good suggestion, I green with @dlg99
-
move DbLedgerStorage.DEFAULT_WRITE_CACHE_MAX_SIZE_MB to ServerConfiguration.DEFAULT_WRITE_CACHE_MAX_SIZE_MB
-
use new code
long writeCacheMaxSize = getLongVariableOrDefault(conf, WRITE_CACHE_MAX_SIZE_MB, conf.getAllocatorPoolingConcurrency()) * MB;
long readCacheMaxSize = getLongVariableOrDefault(conf, READ_AHEAD_CACHE_MAX_SIZE_MB, conf.getAllocatorPoolingConcurrency()) * MB;
instead of
long writeCacheMaxSize = getLongVariableOrDefault(conf, WRITE_CACHE_MAX_SIZE_MB, DEFAULT_WRITE_CACHE_MAX_SIZE_MB) * MB;
long readCacheMaxSize = getLongVariableOrDefault(conf, READ_AHEAD_CACHE_MAX_SIZE_MB, DEFAULT_READ_CACHE_MAX_SIZE_MB) * MB;
StevenLuMT
requested changes
Jul 29, 2022
Member
StevenLuMT
left a comment
StevenLuMT
left a comment
There was a problem hiding this comment.
can you add a testcase to cover the new function?
# Conflicts: # bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java
hangc0276
requested changes
Jul 31, 2022
| log.info(" - Number of directories: {}", numberOfDirs); | ||
| log.info(" - Write cache size: {} MB", writeCacheMaxSize / MB); | ||
| log.info(" - Read Cache: {} MB", readCacheMaxSize / MB); | ||
| log.info(" - Write cache size: {} MB", writeCacheMaxSize / 1024 / 1024); |
| public int getAllocatorPoolingConcurrency() { | ||
| long writeCacheSize = this.getWriteCacheMaxSize(); | ||
| long readCacheSize = this.getReadCacheMaxSize(); | ||
| long availableDirectMemory = PlatformDependent.maxDirectMemory() - writeCacheSize - readCacheSize; |
Contributor
There was a problem hiding this comment.
Please use PlatformDependent.estimateMaxDirectMemory() instead of PlatformDependent.maxDirectMemory(). Please refer to: #2989
Contributor
There was a problem hiding this comment.
In dbLedgerStorage,
- If we use
DefaultEntryLogger, only the whole write-cache will be allocated at one time in the init state, and the read-cache will be allocated on-demand. - If we use
DirectEnryLogger, both the write-cache and the read-cache are allocated on-demand.
So I think we'd better keep the default implementation.
Member
|
fix old workflow,please see #3455 for detail |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
This is a patch #3001. Consider unpooled direct memory on DbLedgerStorage.