Fix wrong key for getHttpServerTrustStorePassword#3643
Fix wrong key for getHttpServerTrustStorePassword#3643wenbingshen wants to merge 1 commit intoapache:masterfrom
Conversation
| */ | ||
| public String getHttpServerTrustStorePassword() { | ||
| return getString(HTTP_SERVER_KEY_STORE_PASSWORD); | ||
| return getString(HTTP_SERVER_TRUST_STORE_PASSWORD); |
There was a problem hiding this comment.
should we handle retrocompatibility here? the risk is that the user upgrades and the webserver doesn't work anymore
at least, we should add highlight in the release notes
There was a problem hiding this comment.
You are right. I think we need add highlight in the release notes.
There was a problem hiding this comment.
Please add fallback to the old property. Also a comment in the code pointing to this pull would be valuable
hangc0276
left a comment
hangc0276
left a comment
There was a problem hiding this comment.
I think we should handle the retro compatibility
|
@merlimat @eolivelli @dlg99 @zymap Please help take a look, thanks. |
| */ | ||
| public String getHttpServerTrustStorePassword() { | ||
| return getString(HTTP_SERVER_KEY_STORE_PASSWORD); | ||
| return getString(HTTP_SERVER_TRUST_STORE_PASSWORD); |
There was a problem hiding this comment.
Please add fallback to the old property. Also a comment in the code pointing to this pull would be valuable
|
Maybe we can mark this config as deprecated and add a new config to restore what it actually does and doc it in the docs and release notes. |
|
@wenbingshen any updates? |
|
closed by #4301 |
5 participants
Motivation
Fix #3639
As the title.