Skip to content

Add force readonly param to RESTful API #4129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
labuladong wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add force readonly param to RESTful API #4129

labuladong wants to merge 3 commits into from

Conversation

@labuladong
Copy link

@labuladong labuladong commented Nov 10, 2023 •
edited
Loading

Motivation

Allow readonly API to force bookie readonly.

@labuladong labuladong mentioned this pull request Nov 10, 2023
Open
3 tasks
@zymap zymap self-requested a review November 10, 2023 04:27
@zymap zymap added this to the 4.17.0 milestone Nov 10, 2023
@zymap
Copy link
Member

zymap commented Nov 14, 2023 

Error:  Errors: 
Error:  org.apache.bookkeeper.server.http.TestHttpService.testBookieReadOnlyState
Error:    Run 1: TestHttpService.testBookieReadOnlyState:983 » NullPointer
Error:    Run 2: TestHttpService.testBookieReadOnlyState:983 » NullPointer
Error:    Run 3: TestHttpService.testBookieReadOnlyState:983 » NullPointer

Seems related to this change

@dragonls
Copy link
Contributor

dragonls commented Nov 23, 2023

The original API already supports setting read-only. Why is the force parameter added here?

@hangc0276
Copy link
Contributor

hangc0276 commented Dec 7, 2023

@labuladong Please rebase the master, thanks.

@eolivelli eolivelli modified the milestones: 4.17.0, 4.18.0 Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zymap zymap Awaiting requested review from zymap

At least 1 approving review is required to merge this pull request.

Assignees

@labuladong labuladong

Labels

type/improvement

Projects

None yet

Milestone

4.18.0

Development

Successfully merging this pull request may close these issues.

5 participants

@labuladong @zymap @dragonls @hangc0276 @eolivelli