Simplify the batching of V2 AddResponses #4405
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use messages as part of the pipeline to avoid ordering issues and to simplify the way how batching is implemented without the need to use synchronized (blocking) methods
hezhangjian
approved these changes
May 29, 2024
dlg99
approved these changes
May 30, 2024
Contributor
|
@lhotari some tests broke, e.g. |
Member
|
reopen's reason: rerun failure checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The batching solution for V2 AddResponses doesn't seem natural for a Netty application.
Batching can be implemented using the Netty Pipeline handlers instead. This avoids synchronization and avoids any possible ordering issues that could be caused when calls are entering in multiple ways.
Changes
Related to changes #3848 and #3837