Skip to content

[fix] Change log level to debug when check parameters in BatchRead. #4485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StevenLuMT merged 2 commits into from
Feb 16, 2025
Merged

[fix] Change log level to debug when check parameters in BatchRead. #4485

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
548b872
Change log level to debug when check parameters in BatchRead.
dao-jun Aug 21, 2024
7093498
fix code style
dao-jun Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -956,13 +956,17 @@ private CompletableFuture<LedgerEntries> batchReadEntriesInternalAsync(long star
boolean isRecoveryRead) {
int nettyMaxFrameSizeBytes = clientCtx.getConf().nettyMaxFrameSizeBytes;
if (maxSize > nettyMaxFrameSizeBytes) {
LOG.info(
"The max size is greater than nettyMaxFrameSizeBytes, use nettyMaxFrameSizeBytes:{} to replace it.",
nettyMaxFrameSizeBytes);
if (LOG.isDebugEnabled()) {
LOG.debug("The max size is greater than nettyMaxFrameSizeBytes, "
+ "use nettyMaxFrameSizeBytes:{} to replace it.", nettyMaxFrameSizeBytes);
}
maxSize = nettyMaxFrameSizeBytes;
}
if (maxSize <= 0) {
LOG.info("The max size is negative, use nettyMaxFrameSizeBytes:{} to replace it.", nettyMaxFrameSizeBytes);
if (LOG.isDebugEnabled()) {
LOG.debug("The max size is negative, use nettyMaxFrameSizeBytes:{} to replace it.",
nettyMaxFrameSizeBytes);
}
maxSize = nettyMaxFrameSizeBytes;
}
BatchedReadOp op = new BatchedReadOp(this, clientCtx,
Expand Down
Loading