Skip to content

Fix check read failed entry memory leak issue. #4513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hangc0276 merged 2 commits into from
May 28, 2025
+5 −0
Merged

Fix check read failed entry memory leak issue. #4513

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f020d4
Fix check read failed entry memory leak issue.
horizonzy Oct 10, 2024
1254a29
address the comments.
horizonzy Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
import org.apache.bookkeeper.client.BookKeeperAdmin;
import org.apache.bookkeeper.client.EnsemblePlacementPolicy;
import org.apache.bookkeeper.client.LedgerChecker;
import org.apache.bookkeeper.client.LedgerEntry;
import org.apache.bookkeeper.client.LedgerFragment;
import org.apache.bookkeeper.client.LedgerHandle;
import org.apache.bookkeeper.client.api.LedgerMetadata;
Expand Down Expand Up @@ -351,6 +352,8 @@ private boolean tryReadingFaultyEntries(LedgerHandle lh, LedgerFragment ledgerFr
lh.asyncReadEntries(entryIdToRead, entryIdToRead, (rc, ledHan, seq, ctx) -> {
long thisEntryId = (Long) ctx;
if (rc == BKException.Code.OK) {
LedgerEntry entry = seq.nextElement();
Copy link
Contributor

@liangyepianzhou liangyepianzhou Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible for seq to have multiple elements? It would be better to check with hasMoreElements here.

Copy link
Member

@StevenLuMT StevenLuMT Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think

  1. hasMoreElements needs to be judged.
  2. at the same time, if (rc == BKException.Code.OK) is true or not, this release needs to be added.
  3. then I suggest adding a testcase to cover it.

Copy link
Member Author

@horizonzy horizonzy Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible for seq to have multiple elements? It would be better to check with hasMoreElements here.

Make sense.

at the same time, if (rc == BKException.Code.OK) is true or not, this release needs to be added.

For this case, if the rc == BKException.Code.OK is false, the seq will be null, we don't need to release the seq.

entry.getEntryBuffer().release();
entriesUnableToReadForThisLedger.remove(thisEntryId);
if (numOfResponsesToWaitFor.decrementAndGet() == 0) {
multiReadComplete.countDown();
Expand Down