Skip to content

Fix: Garbage collection stuck on corrupt entry log file #4544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eolivelli merged 1 commit into from
Feb 13, 2025
+7 −2
Merged

Fix: Garbage collection stuck on corrupt entry log file #4544

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,8 +823,13 @@ protected void extractMetaFromEntryLogs() throws EntryLogMetadataMapException {
entryLogMetaMap.put(entryLogId, entryLogMeta);
}
} catch (IOException | RuntimeException e) {
LOG.warn("Premature exception when processing " + entryLogId
+ " recovery will take care of the problem", e);
LOG.warn("Premature exception when processing {} recovery will take care of the problem",
entryLogId, e);
} catch (OutOfMemoryError oome) {
// somewhat similar to https://github.com/apache/bookkeeper/pull/3901
// entrylog file can be corrupted but instead having a negative entry size
// it ends up with very large value for the entry size causing OODME
LOG.warn("OutOfMemoryError when processing {} - skipping the entry log", entryLogId, oome);
}
}
}
Expand Down
Loading