Every time use KeyValueStorage.Batch, close it in finally #4576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StevenLuMT
changed the title
AnonHxy
approved these changes
Apr 9, 2025
liangyepianzhou
approved these changes
Apr 9, 2025
hezhangjian
reviewed
Apr 9, 2025
Member
hezhangjian
left a comment
hezhangjian
left a comment
There was a problem hiding this comment.
Can we put newBatch in the try statements?
StevenLuMT
force-pushed
the
master-addFinalRelease
branch
from
151d81c to
22e4ecf
Compare
Member
Author
Good suggestion, I changed the way of coding it, let's take a look @hezhangjian |
hezhangjian
approved these changes
Apr 9, 2025
zymap
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Motivation
Using KeyValueStorage.Batch more rigorously: use KeyValueStorage.Batch, close it in finally.
This modification is not caused by a fault. I just found that the code is not written rigorously enough and is prone to bugs when I was combing through it.
Changes