#4574: fix sanity check asyncBatchReadEntries #4579
Merged
+41
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@mazzucchi-andrea If possible, I think I'd add a startEntry < 0 exception test case |
xiezhx9
approved these changes
Apr 15, 2025
hezhangjian
reviewed
Apr 15, 2025
Member
hezhangjian
left a comment
hezhangjian
left a comment
There was a problem hiding this comment.
Can startEntry less than zero?
Contributor
Author
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #4574
Motivation
The little sanity check in the method asyncBatchReadEntries in LedgerHandle does not check if the entrId is equal to or grater
to zero.
Changes
The method validates the input only for
startEntry > lastAddConfirmed. This fix makes it compliant to the other reader methods and validates the input like thisstartEntry < 0 || startEntry > lastAddConfirmed.