improve: Resolve hostname only when useHostNameAsBookieID is enabled #4583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The existing implementation always resolves the default hostname for the specified network interface, even when
useHostNameAsBookieIDis disabled. This is unnecessary and can introduce resolution failures or delays in environments where DNS is misconfigured or unavailable.Restricting hostname resolution to only when
useHostNameAsBookieIDis enabled improves efficiency and avoids potential issues related to unnecessary hostname lookups.Changes
Moved hostname resolution logic under the
useHostNameAsBookieIDcondition.When
useHostNameAsBookieIDis false, the code now directly usesDNS.getDefaultIP(iface)to obtain the IP address.