Skip to content

Conversation

@lhotari
Copy link
Member

@lhotari lhotari commented Apr 16, 2025

Motivation

Changes

  • Upgrade Netty to 4.1.119.Final
    • Comes with tcnative 2.0.70.Final
  • Upgrade netty-transport-native-io_uring to 0.0.26.Final

@nodece
Copy link
Member

nodece commented Apr 16, 2025

BookKeeper CI / Replication Tests (pull_request) CI always fails, because the DNS resolve time is too long, which leads to the test timeout.

@lhotari
Copy link
Member Author

lhotari commented Apr 16, 2025

BookKeeper CI / Replication Tests (pull_request) CI always fails, because the DNS resolve time is too long, which leads to the test timeout.

@nodece interesting. In a different context, a reporter in this Pulsar GH discussion was saying that something changed in Netty DNS resolution in the upgrade.

@nodece
Copy link
Member

nodece commented Apr 16, 2025

@lhotari The bk did not use the netty dns resolver, I will use the netty dns resolver instead of the java built-in dns resolver, please see #4585

@lhotari
Copy link
Member Author

lhotari commented Apr 16, 2025

@lhotari The bk did not use the netty dns resolver, I will use the netty dns resolver instead of the java built-in dns resolver, please see #4585

@nodece Although there are benefits in using Netty's DNS resolver, I wonder if this test flakiness is simply due to default DNS caching settings in Java.

@nodece
Copy link
Member

nodece commented Apr 16, 2025

In the local network environment, the DNS resolution process takes as long as 15 seconds, it seems that the Java did not cache the DNS info.

@lhotari
Copy link
Member Author

lhotari commented Apr 16, 2025

commented at #4585 (comment)

@lhotari
Copy link
Member Author

lhotari commented Apr 16, 2025

In the local network environment, the DNS resolution process takes as long as 15 seconds.

That's possibly due to the default negative DNS cache setting of 10 seconds. Have you tested with these changes: #4585 (comment) .

@nodece
Copy link
Member

nodece commented Apr 16, 2025

I will test that with your suggestion tomorrow.

@lhotari
Copy link
Member Author

lhotari commented Apr 16, 2025

@nodece I created #4586 to tune the DNS TTL settings for tests and for CI

Copy link
Member

@StevenLuMT StevenLuMT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great jobs

@lhotari lhotari merged commit 02d7f9f into apache:master Apr 16, 2025
23 checks passed
lhotari added a commit that referenced this pull request Apr 16, 2025
lhotari added a commit that referenced this pull request Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants