fix: Add strict hostname resolution and loopback check for advertised address #4595
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#4588 uses
java.net.InetAddress#getCanonicalHostNameto resolve the hostname. However, if the operating system is unable to resolve a hostname for the given IP address, this method may simply return the IP address. This can lead to unexpected behavior whenuseHostNameAsBookieIDis enabled — in such cases, we expect a hostname, not an IP.Additionally, the advertised address should not be a loopback address unless explicitly allowed by
allowLoopback.If the user uses the loopback address as advertised, this change may introduce a breaking change.
Changes
allowLoopbackisfalse.