-
Notifications
You must be signed in to change notification settings - Fork 964
Optimize ListActiveLedgersCommand #4602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize ListActiveLedgersCommand #4602
Conversation
8c6f0a4 to
37e70ed
Compare
37e70ed to
d614cf3
Compare
...er/src/main/java/org/apache/bookkeeper/tools/cli/commands/bookie/ReadLogMetadataCommand.java
Show resolved
Hide resolved
.../src/main/java/org/apache/bookkeeper/tools/cli/commands/bookie/ListActiveLedgersCommand.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good jobs
|
You have 2 Checkstyle violations: |
|
rerun failure checks |
|
@hezhangjian @zymap help review,thanks |
hezhangjian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
xiezhx9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation
bookkeepr shell activeledgers.Currently
activeledgersonly print the ledger id of the active ledgers. if we want to know the size of the active ledgers in then entry log, we need caculate manually.In this PR, we will also print the active ledgers and the usage of the entrylog.
No more print usage of the entrylog in
bookkeepr shell readlogmetadata, because the usage will always be1.0which is a false result.Examples after optimization
bin/bookkeeper shell activeledgersbefore:


after:
bin/bookkeeper shell readlogmetadatabefore:


after:
Changes
activeledgerscmdreadlogmetadatacmd