[CALCITE-6687] Add dependency constraints for org.ow2.asm for Gradle … #264
Conversation
stoty
force-pushed
the
CALCITE-6687
branch
2 times, most recently
from
8eae6f0 to
ecb6c53
Compare
zabetak
left a comment
zabetak
left a comment
There was a problem hiding this comment.
How we can be sure that constraints are enforced correctly? In other words, how do we test this PR?
zabetak
left a comment
zabetak
left a comment
There was a problem hiding this comment.
LGTM, the only thing that I would change before merging is to read the property from the gradle.properties file as suggested.
On a more general topic, we should not be forced to fine-tune deps for plugins but rather upgrade the version plugin itself. I understand that we cannot do it now since JDK8 is unsupported in more recent version but I guess we should start discussing till when we are going to support the JDK8 on our side. Eventually we are gonna reach a point that workarounds like this one are not gonna work.
#257 fails with the default asm version. If that builds successfully, then the constraints are enforced. |
|
We can also check that constraints are enforced via |
|
Thank you, I have added the suggested property references, this is a much better solution. As for JDK 8 support, I agree that it is generally a pain, and is only getting worse, but some projects using Avatica still support JDK8. |
…build environment in Avatica
|
rebased and merged commits |
3 participants
…build environment