Skip to content

Conversation

@caicancai
Copy link
Member

@caicancai caicancai commented Nov 17, 2024

@stoty
Copy link
Contributor

stoty commented Nov 18, 2024

The test failures look related.
Maybe hsqldb.version also needs to be synced ?

@caicancai
Copy link
Member Author

The test failures look related. Maybe hsqldb.version also needs to be synced ?

I'll try it later, thanks for the reminder

@caicancai
Copy link
Member Author

@stoty It looks like some of the data in the test set has been transformed. I’m not sure whether to continue this work. Do you have any suggestions?

@stoty
Copy link
Contributor

stoty commented Nov 25, 2024

Is the hsql update a security issue ?
If not, I'd just leave it alone, it's only used for tests.

Otherwise, all the tests using the dataset and hsql would need to be checked and updated to work with the new HSQL and test data.

@caicancai caicancai closed this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants