[CALCITE-6729] Ensure TypedValue allows sub-types for local representations #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaibudiu
approved these changes
Dec 11, 2024
Contributor
|
Change looks good, but commit message must be changed to standard format and must describe the bug for someone with zero context. |
NobiGo
approved these changes
Dec 12, 2024
Contributor
NobiGo
left a comment
NobiGo
left a comment
There was a problem hiding this comment.
We need to change the commit info to [CALCITE-XXXX] XXXXX.
chrisdennis
force-pushed
the
calcite-6729
branch
from
3a5c9b2 to
43ace08
Compare
chrisdennis
changed the title
Contributor
Author
|
I've reworded and reformatted this to align with contributor guidelines. Let me know if the commit message needs more expansion. |
Contributor
Author
|
@mihaibudiu anything I can (or should) be doing to expedite things here? |
Contributor
|
I will merge this if CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.