[CALCITE-6066] Add HYPOT function (enabled in Spark library) #4720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzifu666
reviewed
Jan 3, 2026
Member
xuzifu666
left a comment
xuzifu666
left a comment
There was a problem hiding this comment.
Compared to the previous implementation, the overall implementation seems OK. I've left some minor comments.
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java
Outdated
Show resolved
Hide resolved
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java
Outdated
Show resolved
Hide resolved
xuzifu666
reviewed
Jan 4, 2026
| f0.checkFails("^hypot(3, 4)^", | ||
| "No match found for function signature HYPOT\\(<NUMERIC>, <NUMERIC>\\)", | ||
| false); | ||
| final SqlOperatorFixture f = f0.withLibrary(SqlLibrary.SPARK); |
Member
There was a problem hiding this comment.
This PR also supports ClickHouse, so should the Library section also include ClickHouse?
xiedeyantu
added
the
LGTM-will-merge-soon
xiedeyantu
force-pushed
the
CALCITE-6066
branch
from
3c05689 to
4c7d3ba
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See CALCITE-6066
Referring to #3489, it appears to be complete, but there are currently conflicts with merging into the main branch, and it hasn't been maintained for a long time. I've resubmitted this PR.