Skip to content

[CALCITE-7398] Incorrect int cast in VariantNonNull#cast for BIGINT #4771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xuzifu666 merged 1 commit into from
Jan 27, 2026
+3 −1
Merged

[CALCITE-7398] Incorrect int cast in VariantNonNull#cast for BIGINT #4771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/java/org/apache/calcite/runtime/variant/VariantNonNull.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ public class VariantNonNull extends VariantSqlValue {
break;
}
case BIGINT: {
long l = (int) value;
long l = (long) value;
switch (type.getTypeName()) {
case TINYINT:
case SMALLINT:
Expand Down
2 changes: 2 additions & 0 deletions testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1868,6 +1868,8 @@ void testCastToBoolean(CastType castType, SqlOperatorFixture f) {
"INTEGER ARRAY");
f.checkScalar("cast(cast('abc' as VARIANT) AS VARCHAR)", "abc", "VARCHAR");
f.checkScalar("cast(cast('abc' as VARIANT) AS CHAR(3))", "abc", "CHAR(3)");
// Test for [CALCITE-7398] Incorrect int cast in VariantNonNull#cast for BIGINT
f.checkScalar("cast(cast(2147483648 as VARIANT) as DECIMAL)", "2147483648", "DECIMAL(19, 0)");
Copy link
Member

@xuzifu666 xuzifu666 Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the bug fix way is OK，but please note:

  1. Your commit message should not contain words like "Fix," and you need to modify the Jira link content to match the PR.
  2. It is recommended to add the corresponding JIRA info to the testCastToBoolean method, or you can add the corresponding comment here.


// Converting a variant to anything that does not match the runtime type returns null
f.checkScalar("cast(cast(1 as VARIANT) as INTEGER)", "1", "INTEGER");
Expand Down
Loading