[CALCITE-7422] Support large plan optimization mode for HepPlanner#4803
Draft
zhuwenzhuang wants to merge 1 commit intoapache:mainfrom
Draft
[CALCITE-7422] Support large plan optimization mode for HepPlanner#4803zhuwenzhuang wants to merge 1 commit intoapache:mainfrom
zhuwenzhuang wants to merge 1 commit intoapache:mainfrom
Conversation
zhuwenzhuang
force-pushed
the
large_plan_mode
branch
6 times, most recently
from
d87d57a to
d4ae34e
Compare
zhuwenzhuang
force-pushed
the
large_plan_mode
branch
from
d4ae34e to
eefc51c
Compare
zhuwenzhuang
force-pushed
the
large_plan_mode
branch
2 times, most recently
from
6369ba1 to
6d9ab05
Compare
Contributor
Author
|
A better iterater implementation of DFS/BFS is needed. I will optimize this later (unavailable for the next two weeks). |
zhuwenzhuang
changed the title
zhuwenzhuang
force-pushed
the
large_plan_mode
branch
from
6d9ab05 to
a5805c8
Compare
zhuwenzhuang
force-pushed
the
large_plan_mode
branch
3 times, most recently
from
b6b03fb to
4c6e984
Compare
Key optimizations of large plan mode: 1. Reusable graph, avoid reinit. 2. Efficient traversal, skip stable subtree. 3. Fine-grained GC. Usage: see comments of HepPlanner() Perf result of LargePlanBenchmark: - 10K unions (~40K nodes): ~8.8s - 100K unions (~400K nodes): ~60.6s Without this mode, such plans will OOM and take very long time(cannot finish).
|
zhuwenzhuang
force-pushed
the
large_plan_mode
branch
from
4c6e984 to
bc8230e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and details: https://issues.apache.org/jira/browse/CALCITE-7422
Before:
LargePlanBenchmark:100 : 1s
LargePlanBenchmark:1000 : 9s
LargePlanBenchmark:10000 : pretty slow, cannot measure.
CPU Profiler Result(enable fired rules cache and disable large plan mode):
fireRule(RelOptRuleCall ruleCall)takes 2% cpu time.Mem Profiler Result(enable fired rules cache and disable large plan mode):
After (enable fired rules cache and large plan mode):
LargePlanBenchmark:100 : 1s
LargePlanBenchmark:1000 : 2s
LargePlanBenchmark:10000 : about 60s
Benchmark (unionNum) Mode Cnt Score Error Units LargePlanBenchmark.testLargeUnionPlan 100 avgt 256.561 ms/op LargePlanBenchmark.testLargeUnionPlan 1000 avgt 1616.421 ms/op LargePlanBenchmark.testLargeUnionPlan 10000 avgt 53393.727 ms/opCPU Profiler Result:
fireRule(RelOptRuleCall ruleCall)takes 11% cpu time. There is still lots of room for CPU optimization.Mem Profiler Result:
(avoid buildListRecurse/collectGarbage, smaller memory peak size)