Skip to content

Conversation

@pkalsi97
Copy link
Contributor

Closes #6388

Changes:

  • Added deprecation warning comment and +camel-k:deprecated=2.9.0 annotation
  • Added TraitCondition to warn users when the trait is enabled
  • Updated tests to expect deprecation condition and added TestMasterTraitDeprecationWarning
  • Auto-generated deprecation badge via gen_doc.sh
  • Added migration guide with RBAC examples and property mappings
  • Updated e2e tests to use Quarkus properties instead of deprecated trait

@squakez Sorry for multiple PRs.. I am trying to solve as many issues as possible in my holiday haha! You can review them whenever you see fit.

Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! Make them coming and don't worry, we're be happy to be overwhelmed by quality PRs as yours!!

I see we're not adding camel-kubernetes dependencies. Likely is because the runtime already have it in "camel-k-runtime". However, for plain-quarkus, the nightly is likely to fail with the missing dependency.

We can merge as is if all tests are passing, and creating a follow up when we see the failure during nightly plain-quarkus execution.

@github-actions
Copy link
Contributor

⚠️ Unit test coverage report - coverage decreased from 51.6% to 51.5% (-0.1%)

@pkalsi97
Copy link
Contributor Author

@squakez Thanks.

@squakez
Copy link
Contributor

squakez commented Dec 14, 2025

@pkalsi97 should we merge this and follow up the eventually failing test on plain-quarkus or are you planning to fix in this PR?

@pkalsi97
Copy link
Contributor Author

@squakez I'll fix it in the PR itself, in some time.

@squakez squakez merged commit b4346a7 into apache:main Dec 14, 2025
10 checks passed
@pkalsi97 pkalsi97 deleted the chore/6388 branch December 14, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate master trait

2 participants