Skip to content

Conversation

@Dekrate
Copy link
Contributor

@Dekrate Dekrate commented Dec 16, 2025

Description

This PR fixes a failing test on CI (Olingo4AppAPITest) related to the previous upgrade of JBang versions. The cause was an outdated assertion in CliConfigITCase.java that still expected version 4.8.0 for cli.service.execute.version, while the system property was correctly updated to 4.16.0.

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

@davsclaus

@github-actions
Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@davsclaus
Copy link
Contributor

There should be tests that uses other versions than 4.16.0 to test that jbang also works with previous versions. So not everything should be 4.16.0. However 4.8.x is very old, so it may be nice to use a 4.14.2 as an example

@Dekrate
Copy link
Contributor Author

Dekrate commented Dec 16, 2025

@davsclaus, I do not quite understand your message. Would you like to have tests that tests 4.16.0 and 4.14.2 or should I replace all to 4.14.2?

@davsclaus
Copy link
Contributor

@davsclaus, I do not quite understand your message. Would you like to have tests that tests 4.16.0 and 4.14.2 or should I replace all to 4.14.2?

Most of them should be 4.16.0. But there should be some tests that purposely test that it works with older releases (like before with 4.8.3 vs 4.8.0) etc.

So can you look at each test and see if you can identify any of those that does that, and then try to make them test with 4.14.2 so we still do tests in that way.

@github-actions github-actions bot removed the dsl label Dec 16, 2025
@davsclaus davsclaus merged commit f3b7f1e into apache:main Dec 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants