Open
Conversation
Croway
approved these changes
Apr 2, 2026
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pull request to correct behavior reported in https://issues.apache.org/jira/browse/CAMEL-23283:
When using camel-observability or camel-micrometer-observability, traces and spans are correctly created and exported for routes triggered by other, tracing-aware framework components (e.g. http). If a route is triggered by a jms message, no trace or span is exported however.
This seems to be caused by missing scope management: MicrometerObservabilitySpanAdapter::activate() only calls span.start() but doesn't put the
span into the tracer's thread-local scope. This means tracer.currentSpan() returns null during route execution, hence the span is invisible to downstream instrumentation that relies on tracer.currentSpan() to find a parent span.
The first commit adds a test to highlight the problem.
The second commit corrects the root cause of the problem, but cause side effects for other tests (the async test cases) which leaks trace information between test execution.
The third commit prevents leaked trace information from being propagated.
Target
mainbranch)Tracking
Apache Camel coding standards and style
I checked that each commit in the pull request has a meaningful subject line and body.
I have run
mvn clean install -DskipTestslocally from root folder and I have committed all auto-generated changes.