CAMEL-23289: Fix empty catch blocks and resource leaks in DrillProducer#22417
Open
CAMEL-23289: Fix empty catch blocks and resource leaks in DrillProducer#22417
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
Contributor
|
🧪 CI tested the following changed modules:
All tested modules (72 modules)
|
Croway
approved these changes
Apr 3, 2026
Contributor
|
sonar workflow is not working #22435 , not specific to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DrillProducer.doStop()withLOG.debug()logging and add null check for connectionStatement/ResultSetclose with try-with-resources inprocess(), fixing a potentialNullPointerExceptionwhenexecuteQuery()throwsTest plan
DrillProducerTestwith 5 tests (all pass)@Disabled)Claude Code on behalf of Andrea Cosentino
🤖 Generated with Claude Code