CAMEL-23260: fix graceful shutdown for ServiceBus consumer (backport 4.18.x)#22444
Open
Croway wants to merge 1 commit intoapache:camel-4.18.xfrom
Open
CAMEL-23260: fix graceful shutdown for ServiceBus consumer (backport 4.18.x)#22444Croway wants to merge 1 commit intoapache:camel-4.18.xfrom
Croway wants to merge 1 commit intoapache:camel-4.18.xfrom
Conversation
Implement ShutdownAware in ServiceBusConsumer to defer shutdown until in-flight exchanges complete their ACK/NACK to Azure Service Bus. Previously, doStop() immediately closed the client, causing RejectedExecutionException and message redelivery when SIGTERM was received during message processing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #22443 to camel-4.18.x.
ShutdownAwareinServiceBusConsumerto defer shutdown until in-flight exchanges complete their ACK/NACK to Azure Service BusdoStop()fromclient.close()toclient.stop()to keep the AMQP connection alive for in-flight message acknowledgementdoShutdown()to close the client only after all exchanges have drainedAtomicIntegercounterTest plan
deferShutdown(),getPendingExchangesSize(),doStop(),doShutdown()mvn verifypasses oncamel-azure-servicebusmodule