Skip to content

feat: remove CI verify-release step to avoid version mismatch and Maven Central timeouts#470

Merged
hsluoyz merged 2 commits intomasterfrom
copilot/fix-ci-error-logging
Dec 19, 2025
Merged

feat: remove CI verify-release step to avoid version mismatch and Maven Central timeouts#470
hsluoyz merged 2 commits intomasterfrom
copilot/fix-ci-error-logging

Conversation

Copy link
Contributor

Copilot AI commented Dec 19, 2025

Semantic release was failing due to @conveyal/maven-semantic-release's verifyRelease step, which enforces strict version matching between pom.xml and git tags, and queries Maven Central (causing 504 timeouts).

Changes

  • pom.xml: Set version to 0.0.0-SNAPSHOT (placeholder value)
  • maven-ci.yml: Removed --verify-release @conveyal/maven-semantic-release from semantic-release command

Approach

Git tags are now the sole source of truth for versioning. The @conveyal/maven-semantic-release prepare step automatically sets the correct version via mvn versions:set before deployment, eliminating the need for version bump commits.

Original prompt

This section details on the original issue you should resolve

<issue_title>[bug] fix CI error</issue_title>
<issue_description>see: https://github.com/casbin/jcasbin/actions/runs/20375591593/job/58553661158

Run npm install -g @conveyal/maven-semantic-release semantic-release
npm warn deprecated semver-diff@5.0.0: Deprecated as the semver package now supports this built-in.
npm warn deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported
npm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm warn deprecated q@1.5.1: You or someone you depend on is using Q, the JavaScript Promise library that gave JavaScript developers strong feelings about promises. They can almost certainly migrate to the native JavaScript promise now. Thank you literally everyone for joining me in this bet against the odds. Be excellent to each other.
npm warn deprecated
npm warn deprecated (For a CapTP with native promises, see @endo/eventual-send and @endo/captp)
npm warn deprecated xml2js-es6-promise@1.1.1: Use xml2js.parseStringPromise(data /*, options */) from the xml2js package instead. https://www.npmjs.com/package/xml2js#promise-usage

added 665 packages in 14s

137 packages are looking for funding
  run `npm fund` for details
[4:16:57 PM] [semantic-release] › ℹ  Running semantic-release version 24.2.9
[4:16:57 PM] [semantic-release] › ✔  Loaded plugin "verifyConditions" from "@semantic-release/github"
[4:16:57 PM] [semantic-release] › ✔  Loaded plugin "verifyConditions" from "@conveyal/maven-semantic-release"
[4:16:57 PM] [semantic-release] › ✔  Loaded plugin "analyzeCommits" from "@semantic-release/commit-analyzer"
[4:16:57 PM] [semantic-release] › ✔  Loaded plugin "verifyRelease" from "@conveyal/maven-semantic-release"
[4:16:57 PM] [semantic-release] › ✔  Loaded plugin "generateNotes" from "@semantic-release/release-notes-generator"
[4:16:57 PM] [semantic-release] › ✔  Loaded plugin "prepare" from "@conveyal/maven-semantic-release"
[4:16:57 PM] [semantic-release] › ✔  Loaded plugin "publish" from "@semantic-release/github"
[4:16:57 PM] [semantic-release] › ✔  Loaded plugin "publish" from "@conveyal/maven-semantic-release"
[4:16:57 PM] [semantic-release] › ✔  Loaded plugin "addChannel" from "@semantic-release/npm"
[4:16:57 PM] [semantic-release] › ✔  Loaded plugin "addChannel" from "@semantic-release/github"
[4:16:57 PM] [semantic-release] › ✔  Loaded plugin "success" from "@semantic-release/github"
[4:16:57 PM] [semantic-release] › ✔  Loaded plugin "fail" from "@semantic-release/github"
[4:16:59 PM] [semantic-release] › ✔  Run automated release from branch master on repository https://github.com/casbin/jcasbin
[4:16:59 PM] [semantic-release] › ✔  Allowed to push to the Git repository
[4:16:59 PM] [semantic-release] › ℹ  Start step "verifyConditions" of plugin "@semantic-release/github"
[4:16:59 PM] [semantic-release] [@semantic-release/github] › ℹ  Verify GitHub authentication (https://api.github.com/)
[4:17:00 PM] [semantic-release] › ✔  Completed step "verifyConditions" of plugin "@semantic-release/github"
[4:17:00 PM] [semantic-release] › ℹ  Start step "verifyConditions" of plugin "@conveyal/maven-semantic-release"
[4:17:00 PM] [semantic-release] [@conveyal/maven-semantic-release] › ℹ  Running @conveyal/maven-semantic-release version 5.0.0
[4:17:00 PM] [semantic-release] [@conveyal/maven-semantic-release] › ℹ  validating pom.xml
[4:17:00 PM] [semantic-release] [@conveyal/maven-semantic-release] › ℹ  pom.xml validation successful
[4:17:00 PM] [semantic-release] [@conveyal/maven-semantic-release] › ℹ  validating maven-settings.xml
[4:17:00 PM] [semantic-release] [@conveyal/maven-semantic-release] › ℹ  maven-settings.xml validation successful
[4:17:00 PM] [semantic-release] › ✔  Completed step "verifyConditions" of plugin "@conveyal/maven-semantic-release"
[4:17:00 PM] [semantic-release] › ℹ  Found git tag v1.85.1 associated with version 1.85.1 on branch master
[4:17:00 PM] [semantic-release] › ℹ  Found 2 commits since last release
[4:17:00 PM] [semantic-release] › ℹ  Start step "analyzeCommits" of plugin "@semantic-release/commit-analyzer"
[4:17:00 PM] [semantic-release] [@semantic-release/commit-analyzer] › ℹ  Analyzing commit: feat: change static ReadWriteLock to instance lock in SyncedEnforcer (#467)
[4:17:00 PM] [semantic-release] [@semantic-release/commit-analyzer] › ℹ  The release type for the commit is minor
[4:17:00 PM] [semantic-release] [@semantic-release/commit-analyzer] › ℹ  Analyzing commit: fix: remove irrelevant links in README
[4:17:00 PM] [semantic-release] [@semantic-release/commit-analyzer] › ℹ  The release type for the commit is patch
[4:17:00 PM] [semantic-release] [@semantic-release/commit-analyzer]...

</details>



<!-- START COPILOT CODING AGENT SUFFIX -->

- Fixes casbin/jcasbin#469

<!-- START COPILOT CODING AGENT TIPS -->
---

✨ Let Copilot coding agent [set things up for you](https://github.com/casbin/jcasbin/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@hsluoyz hsluoyz marked this pull request as ready for review December 19, 2025 17:05
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.31%. Comparing base (1229948) to head (c6d7217).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #470   +/-   ##
=======================================
  Coverage   67.31%   67.31%           
=======================================
  Files          60       60           
  Lines        3004     3004           
  Branches      559      559           
=======================================
  Hits         2022     2022           
  Misses        802      802           
  Partials      180      180           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix CI error due to deprecated packages fix: remove verify-release step to avoid version mismatch and Maven Central timeouts Dec 19, 2025
Copilot AI requested a review from hsluoyz December 19, 2025 17:10
@hsluoyz hsluoyz changed the title fix: remove verify-release step to avoid version mismatch and Maven Central timeouts feat: remove CI verify-release step to avoid version mismatch and Maven Central timeouts Dec 19, 2025
@hsluoyz hsluoyz merged commit bd17fb7 into master Dec 19, 2025
2 of 4 checks passed
hsluoyz added a commit that referenced this pull request Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants