chore(benchmark): switch JMH output time unit to nanoseconds#476
Closed
DeProfunds wants to merge 10 commits intoapache:masterfrom
Closed
chore(benchmark): switch JMH output time unit to nanoseconds#476DeProfunds wants to merge 10 commits intoapache:masterfrom
DeProfunds wants to merge 10 commits intoapache:masterfrom
Conversation
|
|
DeProfunds
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
JMH benchmarks in jCasbin were reporting
time/opin milliseconds via@OutputTimeUnit(TimeUnit.MILLISECONDS), while Casbin (Go) benchmarks commonly usens/op. Even when the underlying work is comparable, differing output units can lead to misinterpretation when comparing absolute performance numbers across languages.Changes
Switched JMH benchmark output time unit from milliseconds to nanoseconds (
@OutputTimeUnit(TimeUnit.NANOSECONDS)) for benchmarks undersrc/test/java/org/casbin/jcasbin/main/benchmark, including:BenchmarkBasicModelBenchmarkABACModelBenchmarkRestfulModelBenchmarkDenyOverrideModelBenchmarkPriorityModelBenchmarkRBACModelSingleBenchmarkRBACModelSmallBenchmarkRBACModelMediumBenchmarkRBACModelLargeBenchmarkRBACModelWithDomainsBenchmarkRBACModelWithResourceRolesVerification
mvn test(passed)