Add github actions for different python versions (and C* 4.0, 4.1, and trunk) #801
Conversation
michaelsembwever
force-pushed
the
mck/python2-gha
branch
2 times, most recently
from
ee14678 to
b70b523
Compare
| 'Programming Language :: Python :: 3.4', | ||
| 'Programming Language :: Python :: 3.5', | ||
| 'Programming Language :: Python :: 3.6' | ||
| 'Programming Language :: Python :: 3.8', |
There was a problem hiding this comment.
3.8 is EOL in October this year, probably it would be better to start from 3.9
There was a problem hiding this comment.
Cassandra 5.0 and trunk need 3.8 and 3.11 support
https://github.com/apache/cassandra/blob/cassandra-5.0/.jenkins/Jenkinsfile#L62
it would be nice to introduce ccm support for 3.12 3.13 3.14 and i tried but there's breakages.
see todo here: https://github.com/apache/cassandra-ccm/pull/801/files#diff-7829468e86c1cc5d5133195b5cb48e1ff6c75e3e9203777f6b2e379d9e4882b3R29
This repo, cassandra-dtest and cassandra-python-driver are the python dependencies that are holding back Cassandra from keeping up to date with newer python versions. This PR is an important step forward in testing foundations.
| 'Programming Language :: Python :: 2', | ||
| 'Programming Language :: Python :: 2.7', | ||
| 'Programming Language :: Python :: 3', |
There was a problem hiding this comment.
Are you sure you want to support 2.x ?
It has reached EOL in 2020
There was a problem hiding this comment.
yes, earlier versions of Cassandra still support 2.7, and run their CI on it, so we have to.
what is required is to release a CCM version first and then pin those earlier Cassandra version tests to it. that way we can then drop python2 support. but we don't have versions of ccm yet.
| ./ccm create test --version='git:cassandra-5.0' -n1 --vnodes --quiet | ||
| ccm_test | ||
| ./ccm create test --version='git:cassandra-5.0.3' -n1 --vnodes --quiet | ||
| ./ccm create test --version='git:trunk' -n1 --vnodes --quiet |
There was a problem hiding this comment.
does not seems correct, trunk is not stable, it may fail because trunk is broken
There was a problem hiding this comment.
trunk should never break it (it has its own tests), and if the breakage is on our side we want to catch that early.
(yeah it introduces some noise for PR authors for a breakage that came else where, and the author has to let the right people know who can step in and help, but catching it early is still beneficial imho)
dkropachev
left a comment
dkropachev
left a comment
There was a problem hiding this comment.
I can't resolve comments, probably have no access, so I just leave them open.
…d trunk) Also always test the latest patch versions patch by Mick Semb Wever; reviewed by Dmitry Kropachev
michaelsembwever
force-pushed
the
mck/python2-gha
branch
from
b70b523 to
e97054d
Compare
|
@dkropachev , can I get your review on CASSANDRA-21079 please 🙏 (it's blocking this PR) |
|
CASSANDRA-21079 has been merged.
|
2 participants
Add github actions for different python versions (and C* 4.0, 4.1, and trunk)
Also always test the latest patch versions