Skip to content

Re-work ordering clause support in query builder #2047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 4.x
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.datastax.oss.driver.api.querybuilder.select;

import com.datastax.oss.driver.api.core.CqlIdentifier;
import com.datastax.oss.driver.api.core.data.CqlVector;
import com.datastax.oss.driver.api.querybuilder.QueryBuilder;
import edu.umd.cs.findbugs.annotations.NonNull;

public class AnnOrderingClause extends OrderingClause {

private final CqlIdentifier identifier;
private final CqlVector<?> vector;

AnnOrderingClause(CqlIdentifier identifier, CqlVector<?> vector) {

this.identifier = identifier;
this.vector = vector;
}

public static AnnOrderingClause create(CqlIdentifier identifier, CqlVector<?> vector) {
return new AnnOrderingClause(identifier, vector);
}

@Override
public void appendTo(@NonNull StringBuilder builder) {
builder.append(" ORDER BY ").append(this.identifier.asCql(true)).append(" ANN OF ");
QueryBuilder.literal(this.vector).appendTo(builder);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.datastax.oss.driver.api.querybuilder.select;

import com.datastax.oss.driver.api.core.CqlIdentifier;
import com.datastax.oss.driver.api.core.metadata.schema.ClusteringOrder;
import com.datastax.oss.driver.internal.querybuilder.ImmutableCollections;
import com.datastax.oss.driver.shaded.guava.common.collect.ImmutableMap;
import edu.umd.cs.findbugs.annotations.NonNull;
import java.util.Map;

public class ColumnsOrderingClause extends OrderingClause {

private final ImmutableMap<CqlIdentifier, ClusteringOrder> orderings;

ColumnsOrderingClause(ImmutableMap<CqlIdentifier, ClusteringOrder> orderings) {

this.orderings = orderings;
}

public static ColumnsOrderingClause create() {
return new ColumnsOrderingClause(ImmutableMap.of());
}

public ColumnsOrderingClause add(
@NonNull CqlIdentifier identifier, @NonNull ClusteringOrder order) {
return new ColumnsOrderingClause(
ImmutableCollections.append(this.orderings, identifier, order));
}

public ColumnsOrderingClause add(@NonNull Map<CqlIdentifier, ClusteringOrder> orderMap) {
return new ColumnsOrderingClause(ImmutableCollections.concat(this.orderings, orderMap));
}

@Override
public void appendTo(@NonNull StringBuilder builder) {

boolean first = true;
for (Map.Entry<CqlIdentifier, ClusteringOrder> entry : orderings.entrySet()) {
if (first) {
builder.append(" ORDER BY ");
first = false;
} else {
builder.append(",");
}
builder.append(entry.getKey().asCql(true)).append(" ").append(entry.getValue().name());
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.datastax.oss.driver.api.querybuilder.select;

import com.datastax.oss.driver.api.querybuilder.CqlSnippet;

public abstract class OrderingClause implements CqlSnippet {}
Loading