Remote vtables #4375
Open
Remote vtables #4375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belliottsmith
force-pushed
the
remote-vtables
branch
2 times, most recently
from
c343bb8 to
4029df8
Compare
belliottsmith
force-pushed
the
trunk
branch
from
4ac0487 to
0b20128
Compare
To support recovering a node that has lost some of its local transaction log, introduce rebootstrap and unsafe bootstrap modes, where Accord ensures no responses are produced for transactions the node cannot be certain it had not previously answered. patch by Benedict and Alex Petrov for CASSANDRA-20908
Also Improve: - Searchable system_accord_debug.txn patch by Benedict; reviewed by Aleksey Yeschenko for CASSANDRA-20899
- Integrate txn_blocked_by deadline and depth filter with execution logic, to ensure we terminate promptly and get a best effort reply
…irtual tables from any node in the cluster patch by Benedict; reviewed by Alex Petrov for CASSANDRA-20900
belliottsmith
force-pushed
the
remote-vtables
branch
from
4029df8 to
03d5e79
Compare
ifesdjeen
approved these changes
Sep 25, 2025
| /** | ||
| * Rebinds matching columns into a new filter; ignores any missing but fails if any are a different type | ||
| */ | ||
| public abstract ColumnFilter rebind(TableMetadata newTable); |
There was a problem hiding this comment.
Seems like a dangerous feature to generally expose. Could we add an assert that this is for virtual tables only, and add a comment that this is not for general use?
| RegularAndStaticColumns fetched = this.queried == this.fetched ? queried : ColumnFilter.rebind(newTable, this.fetched); | ||
| SortedSetMultimap<ColumnIdentifier, ColumnSubselection> subSelections = this.subSelections; | ||
| if (subSelections != null) | ||
| subSelections = TreeMultimap.create(subSelections); |
There was a problem hiding this comment.
Could you elaborate, why we need to re-wrap this? I thought this should be effectively immutable.
| // we don't add static columns as they can't be modelled correctly with the insertion of a prefix partition column | ||
| for (ColumnMetadata cm : local.regularColumns()) | ||
| { | ||
| if (!cm.isComplex()) |
There was a problem hiding this comment.
Should e maybe throw in case of complex columns? I know we're not using them anywhere, but maybe worth to throw in case we have intention for this to be used elsewhere.
|
I've also pushed a test; please feel free to remove on commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for sending a pull request! Here are some tips if you're new here:
Commit messages should follow the following format:
The Cassandra Jira