Skip to content

CASSANDRA-20944 Disable mutation tracking by default in CassandraGenerators #4413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+0 −17
Closed

CASSANDRA-20944 Disable mutation tracking by default in CassandraGenerators #4413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions test/unit/org/apache/cassandra/utils/CassandraGenerators.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,6 @@ public Gen<KeyspaceMetadata> build()
AbstractReplicationStrategy replication = replicationGen.generate(rs).withKeyspace(nameGen).build(replicationType).generate(rs);
ReplicationParams replicationParams = ReplicationParams.fromStrategy(replication);
boolean durableWrites = durableWritesGen.generate(rs);
// TODO: Support tracked
KeyspaceParams params = new KeyspaceParams(durableWrites, replicationParams, FastPathStrategy.simple(), replicationType);
Tables tables = Tables.none();
Views views = Views.none();
Expand Down Expand Up @@ -958,7 +957,6 @@ public static class TableMetadataBuilder
private Gen<Integer> numClusteringColumnsGen = SourceDSL.integers().between(1, 2);
private Gen<Integer> numRegularColumnsGen = SourceDSL.integers().between(1, 5);
private Gen<Integer> numStaticColumnsGen = SourceDSL.integers().between(0, 2);
private Gen<ReplicationType> replicationTypeGen = SourceDSL.arbitrary().enumValues(ReplicationType.class);
@Nullable
private ColumnNameGen columnNameGen = null;
private TableParamsBuilder paramsBuilder = new TableParamsBuilder();
Expand Down Expand Up @@ -999,19 +997,6 @@ public TableMetadataBuilder withPartitioner(IPartitioner partitioner)
return withPartitioner(i -> partitioner);
}

public TableMetadataBuilder withReplicationType(Gen<ReplicationType> replicationTypeGen)
{
this.replicationTypeGen = Objects.requireNonNull(replicationTypeGen);
return this;
}

public TableMetadataBuilder withReplicationType(ReplicationType replicationType)
{
return withReplicationType(r -> replicationType);
}



public TableMetadataBuilder withUseCounter(boolean useCounter)
{
return withUseCounter(ignore -> useCounter);
Expand Down Expand Up @@ -1199,12 +1184,10 @@ public TableMetadata build(RandomnessSource rnd)
String tableName = tableNameGen.generate(rnd);
TableParams params = paramsBuilder.build().generate(rnd);
boolean isCounter = useCounter.generate(rnd);
ReplicationType replicationType = replicationTypeGen.generate(rnd);
TableMetadata.Builder builder = TableMetadata.builder(ks, tableName, tableIdGen.generate(rnd))
.partitioner(partitionerGen.generate(rnd))
.kind(tableKindGen.generate(rnd))
.isCounter(isCounter)
.keyspaceReplicationType(replicationType)
.params(params);

int numPartitionColumns = numPartitionColumnsGen.generate(rnd);
Expand Down