Skip to content

[CELEBORN-2183] Fix client tries to start a connection with excluded workers #3517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
r7raul1984 wants to merge 5 commits into from
+3 −1
Closed

[CELEBORN-2183] Fix client tries to start a connection with excluded workers #3517

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a11ceda
[CELEBORN-2183]Client always tries to start a connection with exclude…
Oct 23, 2025
db03e20
[CELEBORN-2183]fix format problem
Oct 23, 2025
e2d92be
[CELEBORN-2183]Should send bufferStreamEnd first before change locati…
Nov 3, 2025
009eb6a
[CELEBORN-2183]add isexcluded check before change to peer
Nov 3, 2025
2b0e5ba
[CELEBORN-2183]using mvn spotless apply to clean the code
Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion client/src/main/java/org/apache/celeborn/client/read/CelebornInputStream.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,9 @@ private PartitionReader createReaderWithRetry(
lastException = e;
shuffleClient.excludeFailedFetchLocation(location.hostAndFetchPort(), e);
fetchChunkRetryCnt++;
if (location.hasPeer() && !readSkewPartitionWithoutMapRange) {
if (location.hasPeer()
&& !isExcluded(location.getPeer())
Copy link
Contributor

@RexXiong RexXiong Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that isExcluded(location.getPeer()) now serves the same purpose as isExcluded(location) at line 455.

Copy link
Author

@r7raul1984 r7raul1984 Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My idea is to add this here to prevent throwing a new CelebornIOException at line 456.

&& !readSkewPartitionWithoutMapRange) {
// fetchChunkRetryCnt % 2 == 0 means both replicas have been tried,
// so sleep before next try.
if (fetchChunkRetryCnt % 2 == 0) {
Expand Down
Loading